kafka-ui icon indicating copy to clipboard operation
kafka-ui copied to clipboard

No warning about filling the invalid data in case of editing the Sche…

Open habrahamyanpro opened this issue 3 years ago • 3 comments

…ma / Producing the Message

  • [ ] Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

  • fixes #2353 Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • [ ] No need to
  • [x] Manually (please, describe, if necessary)
  • [ ] Unit checks
  • [ ] Integration checks
  • [ ] Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • [x] My changes generate no new warnings (e.g. Sonar is happy)
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

habrahamyanpro avatar Sep 16 '22 14:09 habrahamyanpro

@habrahamyanpro pls run pnpm test first. I see 2 broken test cases

workshur avatar Sep 19 '22 08:09 workshur

is ready

habrahamyanpro avatar Sep 20 '22 11:09 habrahamyanpro

@Haarolean pls take a look 👀

workshur avatar Sep 29 '22 08:09 workshur

@BulatKha PTAL

Haarolean avatar Sep 29 '22 08:09 Haarolean

Custom deployment will be available at http://pr2599.internal.kafka-ui.provectus.io

github-actions[bot] avatar Sep 29 '22 08:09 github-actions[bot]

I will check this.

armenuikafka avatar Oct 04 '22 07:10 armenuikafka

@habrahamyanpro at http://pr2599.internal.kafka-ui.provectus.io/ the bug still exists.

armenuikafka avatar Oct 11 '22 09:10 armenuikafka

Custom deployment removed

github-actions[bot] avatar Oct 11 '22 09:10 github-actions[bot]

Custom deployment will be available at http://pr2599.internal.kafka-ui.provectus.io

github-actions[bot] avatar Oct 18 '22 13:10 github-actions[bot]

Custom deployment removed

github-actions[bot] avatar Oct 19 '22 04:10 github-actions[bot]

@VladSenyuta that happened again

Haarolean avatar Oct 19 '22 17:10 Haarolean

@VladSenyuta that happened again

@habrahamyanpro we're facing some kinky formatting while sending keys by AQA framework to the field '#newSchema [wrap]'. I've tried to do this using different ways, but it still breaks json format image that's why because of hard validation we're getting failed test

can we turn off that formatting? btw in doesn't work at CreateSchemaScreen and we're Ok with it, Schema field correctly receive String with Json syntax (attached) image @Haarolean FYI

VladSenyuta avatar Oct 20 '22 08:10 VladSenyuta

Custom deployment will be available at http://pr2599.internal.kafka-ui.provectus.io

github-actions[bot] avatar Mar 13 '23 12:03 github-actions[bot]

Custom deployment removed

github-actions[bot] avatar Mar 13 '23 13:03 github-actions[bot]

Custom deployment will be available at http://pr2599.internal.kafka-ui.provectus.io

github-actions[bot] avatar Mar 13 '23 13:03 github-actions[bot]

Custom deployment removed

github-actions[bot] avatar Mar 13 '23 16:03 github-actions[bot]

Custom deployment will be available at http://pr2599.internal.kafka-ui.provectus.io

github-actions[bot] avatar Mar 13 '23 16:03 github-actions[bot]

Custom deployment removed

github-actions[bot] avatar Mar 14 '23 12:03 github-actions[bot]

not sure if this solution is good for the PROTOBUF

David-DB88 avatar Mar 24 '23 15:03 David-DB88

@David-DB88 can't see custom deployment link

armenuikafka avatar Mar 30 '23 05:03 armenuikafka

Custom deployment will be available at http://pr2599.internal.kafka-ui.provectus.io

github-actions[bot] avatar Mar 30 '23 09:03 github-actions[bot]

@armenuikafka the link is now available

David-DB88 avatar Mar 30 '23 11:03 David-DB88