kafka-ui icon indicating copy to clipboard operation
kafka-ui copied to clipboard

Published 20 hours ago • verified publisher icon provectus

Broker configs: allow resetting values to nulls

Open Haarolean opened this issue 3 years ago • 5 comments

Currently if you change a broker property with null value to something non-null it's not possible to set it back to null. Not supported by both backend and frontend.

Haarolean avatar Sep 15 '22 00:09 Haarolean

@Haarolean Can you please assign this to me ?

shubhwip avatar Sep 16 '22 09:09 shubhwip

@Haarolean Can you please add more details to this issue ?

shubhwip avatar Sep 16 '22 13:09 shubhwip

@Haarolean Can you please add more details to this issue ?

done :)

Haarolean avatar Sep 16 '22 13:09 Haarolean

@Haarolean How can i change kafka broker properties through the Kafka-UI or by other means, Can you give some steps please to reproduce the behaviour :) ? Also are we talking broker properties in the context of topics/messages ?

shubhwip avatar Sep 16 '22 16:09 shubhwip

@Haarolean How can i change kafka broker properties through the Kafka-UI or by other means, Can you give some steps please to reproduce the behaviour :) ? Also are we talking broker properties in the context of topics/messages ?

that's our new feature (#712), every broker in a table is clickable, there's a tab "configs" inside (url: /ui/clusters/local/brokers/0/configs).

Haarolean avatar Sep 16 '22 18:09 Haarolean

@Haarolean I tried this bug on latest master.

  • If we set a null field to some value then value is not reflected right way, not sure if it is intended behaviour. Shall we fix this behaviour ?
  • If we change a broker property with null value to something non-null then we are able to set it back to null, we have to refresh the page and it will be in effect.

shubhwip avatar Oct 14 '22 09:10 shubhwip

@shubhwip

  • how does it work then?
  • can we do this without a refresh?

Haarolean avatar Oct 14 '22 09:10 Haarolean

@shubhwip

  • how does it work then?

I needed to refresh the page to see updated value.

  • can we do this without a refresh?

Let me check.

shubhwip avatar Oct 14 '22 09:10 shubhwip

I needed to refresh the page to see updated value.

looks like a bug to me.

Haarolean avatar Oct 14 '22 09:10 Haarolean

@shubhwip and this one? :-)

Haarolean avatar Dec 07 '22 08:12 Haarolean

@Haarolean I will do it probably this weekend or next.

shubhwip avatar Dec 07 '22 21:12 shubhwip

I tried to reproduce this issue on latest master today and

  • set a field with null value(for e.g. log.flush.interval.ms) to non null value
  • when i try to set it back to null then there are some errors on the kafka side i.e. 2022-12-18 19:59:29 org.apache.kafka.common.errors.InvalidRequestException: Invalid value null for configuration log.flush.interval.ms: Not a number of type LONG Same error happens with some of other properties and then kafka-ui throws 400 response.

Not sure if this is something we need to work on because kafka is handling it this way.

Some null properties can't be changed as I tried to set a field ssl.key.password which was null. 2022-12-18 20:07:59 org.apache.kafka.common.errors.InvalidRequestException: These security configs can be dynamically updated only per-listener using the listener prefix: HashSet(ssl.key.password)

shubhwip avatar Dec 18 '22 20:12 shubhwip

@shubhwip thanks! We'll discuss thing thingy

Haarolean avatar Dec 19 '22 18:12 Haarolean