kafka-ui icon indicating copy to clipboard operation
kafka-ui copied to clipboard

Fix backend tests stability on m1/arm

Open Haarolean opened this issue 2 years ago • 5 comments

Backend tests on m1 work way too bad

Haarolean avatar Aug 15 '22 13:08 Haarolean

I suggest we expand the scope of this issue: I think we might need arm images for backend tests as well. We've already got some logic to choose arm images over x86 depending on the architecture (com.provectus.kafka.ui.base.BaseTest#isARM64).

Haarolean avatar Aug 30 '22 10:08 Haarolean

I suggest we expand the scope of this issue: I think we might need arm images for backend tests as well. We've already got some logic to choose arm images over x86 depending on the architecture (com.provectus.kafka.ui.base.BaseTest#isARM64).

@shubhwip wanna give it a try? :)

Haarolean avatar Aug 30 '22 10:08 Haarolean

Sure @Haarolean

shubhwip avatar Aug 30 '22 11:08 shubhwip

I ran the e2e tests locally and one of the tests failed was UpdateAvroSchema in kafka-ui-e2e-checks/src/test/java/com/provectus/kafka/ui/tests/SchemasTests.java Here are the screenshots Screenshot 2022-09-04 at 1 19 44 PM

1662271406945 0

Errors on schema registry side

io.confluent.kafka.schemaregistry.rest.exceptions.RestIncompatibleSchemaException: Schema being registered is incompatible with an earlier schema for subject "ab"
	at io.confluent.kafka.schemaregistry.rest.exceptions.Errors.incompatibleSchemaException(Errors.java:133)

The reason why it is failing because during update we are changing a top level property and we have created this schema with backward compatibility. Although in our test we are switching to compatibility to None but that didn't have any effect because compatibility is set to backward_compatible globally. So in order for this test to work we need to keep top level property same i.e. name.

Then again I don't get why e2e test passes on some PRs :) ?

shubhwip avatar Sep 04 '22 07:09 shubhwip

I ran the e2e tests locally and one of the tests failed was UpdateAvroSchema in kafka-ui-e2e-checks/src/test/java/com/provectus/kafka/ui/tests/SchemasTests.java Here are the screenshots Screenshot 2022-09-04 at 1 19 44 PM

1662271406945 0

Errors on schema registry side

io.confluent.kafka.schemaregistry.rest.exceptions.RestIncompatibleSchemaException: Schema being registered is incompatible with an earlier schema for subject "ab"
	at io.confluent.kafka.schemaregistry.rest.exceptions.Errors.incompatibleSchemaException(Errors.java:133)

The reason why it is failing because during update we are changing a top level property and we have created this schema with backward compatibility. Although in our test we are switching to compatibility to None but that didn't have any effect because compatibility is set to backward_compatible globally. So in order for this test to work we need to keep top level property same i.e. name.

Then again I don't get why e2e test passes on some PRs :) ?

@shubhwip thanks for the note, I suppose we can discuss this issue with that test with our QA folks. You can ignore it failing locally for now. @provectus/kafka-qa @VladSenyuta fyi

Haarolean avatar Sep 13 '22 02:09 Haarolean

@ArthurNiedial FYI

VladSenyuta avatar Sep 26 '22 10:09 VladSenyuta

Currently, tests do seem to work fine with replacing CONFLUENT_PLATFORM_VERSION in AbstractIntegrationTest to 7.2.1.arm64.

Haarolean avatar Aug 03 '23 11:08 Haarolean