kafka-ui icon indicating copy to clipboard operation
kafka-ui copied to clipboard

In case of using "," symbol system doesn't give the validation message for Topic name field #2203

Open MichaelGonzalezMurillo opened this issue 2 years ago • 1 comments

  • [ ] Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Fixes #2203

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • [ ] No need to
  • [x] Manually (please, describe, if necessary)
  • [x] Unit checks
  • [ ] Integration checks
  • [ ] Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • [x] My changes generate no new warnings (e.g. Sonar is happy)
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

MichaelGonzalezMurillo avatar Aug 10 '22 21:08 MichaelGonzalezMurillo

@armenuikafka Could you please take a look?

workshur avatar Aug 11 '22 08:08 workshur

Custom deployment will be available at http://pr2425.internal.kafka-ui.provectus.io

github-actions[bot] avatar Aug 11 '22 08:08 github-actions[bot]

@workshur works correctly !

armenuikafka avatar Aug 12 '22 04:08 armenuikafka

@MichaelGonzalezMurillo super cool, thanks

Haarolean avatar Aug 12 '22 11:08 Haarolean

Custom deployment removed

github-actions[bot] avatar Aug 12 '22 11:08 github-actions[bot]