#2375 smart filter fix

[kristi-dev]

• [x] Breaking change? (if so, please describe the impact and migration path for existing application instances)

Fix smart filter with multiple conditions #2375

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

• [ ] No need to
• [x] Manually (please, describe, if necessary)
• [ ] Unit checks
• [ ] Integration checks
• [ ] Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

• [x] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
• [x] My changes generate no new warnings (e.g. Sonar is happy)
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] New and existing unit tests pass locally with my changes
• [ ] Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

[workshur]

@armenuikafka @Haarolean pls review it works as expected

[github-actions[bot]]

Custom deployment will be available at http://pr2400.internal.kafka-ui.provectus.io

[mk-khan]

@anezboretskiy @Haarolean thanks for pushing this to master, I have downloaded the new docker image from kafka-ui:master, however, when i have the filter set to "value.Id == "SiR_SG00079XX1.G1" && value.Idx == 1003" then i am still seeing values for value.Idx 1003 and 1006. Is there something I am missing while using the filter ?

[Haarolean]

@mk-khan nothing has been pushed so far

[mk-khan]

@Haarolean ok, looking forward this to be merged to master at least. Thanks again

[mk-khan]

@Haarolean any chance this PR can be merged to master? I needed this filter capability to test some data issues we are having.. appreciate if someone can merge it..

[Haarolean]

@mk-khan It will get merged the moment review is done

[armenuikafka]

Filter works correctly with 2 conditions in http://pr2400.internal.kafka-ui.provectus.io/

[mk-khan]

@armenuikafka, I tried to build from the master and still having the same issue. out of two filters only one get applied and the other does not. Could you please let me know if there is other docker image that i can try to make this work on our end.

[armenuikafka]

@mk-khan hey! let's try to check once it will be merged to master. If the issue will be actual after merge, let us know.

[Haarolean]

@KriKiparoidze let's resolve the conflicts and merge

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[github-actions[bot]]

Custom deployment removed

[Haarolean]

@mk-khan available as master-labeled docker image

[mk-khan]

Thank you so much, I will update my build and let you know if any issues.

On Thu, 18 Aug 2022, 10:52 pm Roman Zabaluev, @.***> wrote:

@mk-khan https://github.com/mk-khan available as master-labeled docker image

— Reply to this email directly, view it on GitHub https://github.com/provectus/kafka-ui/pull/2400#issuecomment-1219455903, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHXH2PYIFDU66EP2RC23IOLVZYWY7ANCNFSM55URZ75Q . You are receiving this because you were mentioned.Message ID: @.***>