kafka-ui icon indicating copy to clipboard operation
kafka-ui copied to clipboard

Prepare steps for Schema Registry and Connector fixed #2288

Open anezboretskiy opened this issue 3 years ago • 0 comments

  • [ ] Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview) -Added two new packages as connectorsteps and schemasteps -Transferred constants in new class like "SchemaConstants" and "ConnectorConstans" -Added new class "SchemaFactory", which working with Supplier and should create schema using key name like "AVRO","JSON","PROTOBUF" -And other adjective changes

Is there anything you'd like reviewers to focus on? -access modifiers of Constants classes -boolean methods and Assertions( will it usability in future ? )

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • [ ] No need to
  • [ ] Manually (please, describe, if necessary)
  • [ ] Unit checks
  • [ ] Integration checks
  • [x] Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • [x] My changes generate no new warnings (e.g. Sonar is happy)
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

anezboretskiy avatar Aug 03 '22 12:08 anezboretskiy