laravel-analytics-event-tracking icon indicating copy to clipboard operation
laravel-analytics-event-tracking copied to clipboard

Adding is_disabled option

Open cheyner opened this issue 2 years ago • 3 comments

cheyner avatar Mar 25 '22 14:03 cheyner

The underlying Analytics package will simply return a NullResponse when prompted to send events to GA if the argument $isDisabled=true in its constructor. Ideally I would have included a test here, but there didn't appear to be a simple way to check that -- and it seemed like a fairly benign adjustment to me.

cheyner avatar Mar 25 '22 14:03 cheyner

@pascalbaljet Can we help merge this in?

kyranb avatar Apr 19 '22 05:04 kyranb

Checking in on this...

cheyner avatar Jun 15 '22 15:06 cheyner

👋 Was looking for a way to disable the package during tests. Currently it sends a ton of requests to Google 😬

sebastiaanluca avatar Nov 22 '22 23:11 sebastiaanluca

I've changed it to is_enabled. Available in v1.5.1 :)

pascalbaljet avatar Dec 10 '22 11:12 pascalbaljet