solhint icon indicating copy to clipboard operation
solhint copied to clipboard

Exclude abi.encodeX calls from func-named-parameters

Open 0xCLARITY opened this issue 1 year ago • 3 comments

Solhint regularly complains about the named-parameters rule when all I'm doing is throwing a bunch of data into abi.encode() or abi.encodePacked().

Rather than annotating every single abi.encodeX() call with a //solhint-disable - I think it makes more sense to exclude abi.encodeX() calls from this rule at the rule implementation.

Tested locally on the contract I'm currently writing and works as expected.

0xCLARITY avatar May 23 '24 17:05 0xCLARITY

@dbale-altoros - I pushed up a commit that I think fixes the linting issues of CI, but I'm not sure how to re-trigger the jobs. Any idea?

0xCLARITY avatar May 28 '24 16:05 0xCLARITY

@dbale-altoros - I pushed up a commit that I think fixes the linting issues of CI, but I'm not sure how to re-trigger the jobs. Any idea?

I need to do that... already passed all of the CI tests... great job

dbale-altoros avatar May 28 '24 18:05 dbale-altoros

@0xCLARITY this week there will be a new release with this addition thanks for the contribution

dbale-altoros avatar Jul 01 '24 13:07 dbale-altoros

@dbale-altoros - any ETA on a new release?

0xCLARITY avatar Jul 15 '24 16:07 0xCLARITY

@0xCLARITY yes sorry I was waiting feedback from this issue https://github.com/protofire/solhint/issues/571 to put both updates together... pretty confident next week will be a new release

dbale-altoros avatar Jul 15 '24 16:07 dbale-altoros