protobuf icon indicating copy to clipboard operation
protobuf copied to clipboard

Allow ByteString to implement Comparable

Open belugabehr opened this issue 5 years ago • 1 comments

What language does this apply to?

If it's about generated code change, what programming language? Java

Describe the problem you are trying to solve.

Use Guava Range/TreeRangeMap with Proto ByteString

Describe the solution you'd like

Make ByteString implement Java Comparable. The natural sorted order should be using the already provided unsignedLexicographicalComparator.

Describe alternatives you've considered

Wrapping ByteString in another object, having Guava Range accept a Comparator,....

ConcurrentSkipListMap<>(UnsignedByteBufComparator.INSTANCE)

belugabehr avatar Aug 24 '20 13:08 belugabehr

Seems reasonable. This would require a Tier 2 review.

elharo avatar Apr 15 '22 16:04 elharo

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

github-actions[bot] avatar Mar 10 '24 10:03 github-actions[bot]

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please reopen it.

This issue was closed and archived because there has been no new activity in the 14 days since the inactive label was added.

github-actions[bot] avatar Mar 25 '24 10:03 github-actions[bot]