protocolbuffers
PHP Extension - Segmentation fault when serialize() is called on a protobuf message
The PHP C extension segfaults when serialize() is called on a protobuf message.
[!IMPORTANT]
This is a unusual use case but the extension should not crash if a proto message is serialize by mistake.
What version of protobuf and what language are you using? Version: main Language: php OS: Linux
What did you do?
<?php
# serialize_segfault.php
require_once (dirname(__DIR__) . '/vendor/autoload.php');
use Foo\TestMessage;
$msg = new TestMessage(['optional_string' => "Hello, World!"]);
serialize($msg);
# Compile the extension
./php/tests/compile_extension.sh
# Run script
php -d display_errors=on -dextension=../ext/google/protobuf/modules/protobuf.so serialize_segfault.php
What did you expect to see
# no errors.
What did you see instead?
Segmentation fault
Patch here
If you're willing to send us your patch as a PR, we would likely accept it (subject to code review).
@FabioBatSilva do you know why serialization isn't supported? Your patch adds an exception but it doesn't look like a bugfix
@FabioBatSilva do you know why serialization isn't supported? Your patch adds an exception but it doesn't look like a bugfix
From what I can tell the extension bypasses a lot of the builtin mechanisms that are necessary for that to work. PHP serialize on a proto message is a bit of an odd use case anyways, so I opted to just prevent the segfault.