protobuf icon indicating copy to clipboard operation
protobuf copied to clipboard

Upgrade to PHPUnit 10

Open TomA-R opened this issue 2 months ago • 2 comments

Upgrades to PHPUnit 10

  • Specify PHPUnit 10 in composer.json. This requires PHP 8.1, but since PHP 8.1 is the oldest version that's not end-of-life, I believe that should be acceptable. From what I can tell, CI also only runs on 8.1+. Older versions of PHPUnit produce a lot of deprecation warnings when run on new versions of PHP, making the output very messy and hard to read.
  • Fixes deprecation warnings:
  • Mark PreviouslyGeneratedClassTest::testPrefixForReservedWords() explicitly as skipped when run on an unsupported version of PHP to avoid a warning: This test did not perform any assertions

TomA-R avatar Oct 21 '25 06:10 TomA-R

Edit: Seems to be a duplicate of https://github.com/protocolbuffers/protobuf/pull/20596

mpesari avatar Nov 28 '25 13:11 mpesari

Thanks @mpesari, I've rebased and fixed the remaining deprecations

TomA-R avatar Nov 29 '25 12:11 TomA-R