protobuf icon indicating copy to clipboard operation
protobuf copied to clipboard

fix(php): Correct uint32 type mapping to use UInt32 instead of Int32

Open TomA-R opened this issue 2 months ago • 2 comments

This fixes the PHP extension's mapping for uint32, which was incorrectly using Int32. I've also added a couple of small tests to cover edge cases in RepeatedField and MapField

TomA-R avatar Oct 19 '25 03:10 TomA-R

Alternatively, it may also make sense to augment php/tests/GeneratedClassTest.php instead.

honglooker avatar Oct 20 '25 22:10 honglooker

Alternatively, it may also make sense to augment php/tests/GeneratedClassTest.php instead.

Thank you for your review, @honglooker! I've added the tests to php/tests/GeneratedClassTest.php and removed the original PHPT tests. I hope that's what you expected, let me know if you'd like me to make any other changes

TomA-R avatar Oct 21 '25 00:10 TomA-R