protobuf icon indicating copy to clipboard operation
protobuf copied to clipboard

[PHP] - phpunit upgrade

Open FabioBatSilva opened this issue 10 months ago • 3 comments

Hi.

This is meant to reduce the noise when running php tests and make the test a bit more friendly.

There is a ton of warnings happening currently due to deprecation on phpunit..

What is included :

  • Upgrade to phpunit 10.5 * Add generated files to git ignore
  • Add phpunit.xml and bootstrap
  • Remove Polyfill for phpunit6

I have a few other PRs coming for issues I have open. And this should make the contributing a bit easier for me other future contributors..

FabioBatSilva avatar Mar 06 '25 22:03 FabioBatSilva

Test failures look like this needs a rebase and retest.

googleberg avatar Oct 03 '25 20:10 googleberg

Test failures look like this needs a rebase and retest.

Done

composer test
# ...
PHPUnit 10.5.58 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.1.33
Configuration: /home/fabio/backup/workspace/cpp/protobuf/php/phpunit.xml.dist

D..............................................................  63 / 462 ( 13%)
............................................................... 126 / 462 ( 27%)
............................................................... 189 / 462 ( 40%)
............................................................... 252 / 462 ( 54%)
............................................................... 315 / 462 ( 68%)
............................................................... 378 / 462 ( 81%)
............................................................... 441 / 462 ( 95%)
.....................                                           462 / 462 (100%)

Time: 00:00.229, Memory: 16.00 MB

OK, but there were issues!
Tests: 462, Assertions: 2879, PHPUnit Deprecations: 13.

FabioBatSilva avatar Oct 06 '25 15:10 FabioBatSilva

Hi,

Would be nice to have this merged and add CI runs for PHP 8.4 and 8.5.

There are still PHPUnit deprecations (phpunit --display-phpunit-deprecations):

14 tests triggered 14 PHPUnit deprecations:                                                                                                                                                                

1) EncodeDecodeTest::testWrapperJsonDecodeAndGet                                                     
Data Provider method EncodeDecodeTest::wrappersDataProvider() is not static
...

mpesari avatar Nov 28 '25 17:11 mpesari