protobuf icon indicating copy to clipboard operation
protobuf copied to clipboard

Comment out non-building rust targets

Open tempoz opened this issue 1 year ago • 3 comments

Comment out all non-building rust targets. This change is in furtherance of my effort to make the protocolbuffers/protobuf repo build free of errors or warnings to make it easier to detect regressions.

tempoz avatar Sep 11 '24 17:09 tempoz

@esrauchg How are we addressing the unbuildability of the rusty bits?

googleberg avatar Sep 11 '24 21:09 googleberg

Thanks for this report / PR showing the issue @tempoz.

It is intended that these targets should work, but due to historical reasons these targets weren't configured to run on GHA and so many of them naturally broke without us noticing (they do run in our internal continuous integration, and the breakages only relate to differences between the internal and open source environments).

Unfortunately we can't accept this PR in its current shape as it would merge badly with our internal copy (where these targets do all work).

I can prioritize getting the corresponding fix on our side (and fixing our GHA Rust config so we would catch such problems in the future).

esrauchg avatar Sep 12 '24 13:09 esrauchg

Of course, close whichever of these aren't helpful. I just was trying to get the repo to build without warnings, and when I eventually succeeded, I figured I'd submit my changes to you guys and you could accept whatever was useful.

tempoz avatar Sep 13 '24 15:09 tempoz