protobuf icon indicating copy to clipboard operation
protobuf copied to clipboard

Update absl to get rid of OOB warning

Open tempoz opened this issue 1 year ago • 3 comments

Without this, there are many instances of a warning about OOB indices inside of string_view in absl.

tempoz avatar Sep 11 '24 16:09 tempoz

@zhangskz My inclination is that we don't want to make this change but I'm open to being convinced. Or maybe we need to persuade ABSL to fix something here?

googleberg avatar Sep 11 '24 22:09 googleberg

https://github.com/abseil/abseil-cpp/commit/50d39219dc5a63f26d3871cfb3dbe198091eadad

This is the fix I'm trying to pick up. Up to you!

tempoz avatar Sep 13 '24 16:09 tempoz

I don't think it makes sense for protobuf to update its absl lower-bound to avoid a spurious warning if its otherwise still compatible, as this could cause other users to fail to find a valid absl version. IIUC, minimal version selection means bzlmod should typically still resolve to a higher version of absl if possible.

It should be sufficient to handle this in the root module via overrides to pin the absl version or by silencing warnings if needed.

zhangskz avatar Sep 13 '24 17:09 zhangskz