protobuf icon indicating copy to clipboard operation
protobuf copied to clipboard

Fix broken namespaces in `hpb_generator/`

Open tempoz opened this issue 1 year ago • 2 comments

The wrong namespaces were being used, and the wrong number of curly braces (!!!) terminated namespaced code. Presumably this is an artifact of a refactor; here is a fix.

tempoz avatar Sep 11 '24 13:09 tempoz

@tempoz - thanks for the fix. It seems like there have been some updates to some of these files in the interval since you opened this PR. Can you rebase and see if the fix is still needed, and if so, resolve the merge conflicts?

JasonLunn avatar Oct 09 '24 18:10 JasonLunn

Done! I think these changes are just as necessary; I don't really understand how these files were supposed to compile before? They all have extra unmatched closing curly braces.

tempoz avatar Oct 16 '24 22:10 tempoz

This'll need internal transformations to complete - I'll take care of that. Thank you for spotting nonetheless!

honglooker avatar Oct 21 '24 13:10 honglooker