protobuf icon indicating copy to clipboard operation
protobuf copied to clipboard

Fix minor typos

Open NathanBaulch opened this issue 1 year ago • 4 comments

Just thought I'd contribute some typo fixes that keep tripping up CI/CD checks in my projects. Nothing controversial (hopefully), just 174 simple fixes.

Use the following command to get a quick and dirty summary of the specific corrections made:

git diff HEAD^! --word-diff-regex='\w+' -U0 \
  | grep -E '\[\-.*\-\]\{\+.*\+\}' \
  | sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \
  | sort | uniq -c | sort -n

FWIW, the top typos are:

  • trimed → trimmed (37)
  • substract → subtract (7)
  • qualifed → qualified (7)
  • extesion → extension (6)
  • mising → missing (5)
  • btye → byte (4)
  • likey → likely (4)
  • candicate → candidate (3)
  • decriptor → descriptor (3)
  • inherting → inheriting (3)
  • colletion → collection (3)
  • caluclated → calculated (3)
  • unititialized → uninitialized (3)
  • implemting → implementing (3)
  • binrary → binary (3)
  • descripor → descriptor (3)
  • negitive → negative (3)

NathanBaulch avatar Aug 01 '24 04:08 NathanBaulch

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 01 '24 04:08 google-cla[bot]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@NathanBaulch Please sign the CLA as soon as possible.

JasonLunn avatar Aug 05 '24 14:08 JasonLunn

@NathanBaulch Please sign the CLA as soon as possible.

I signed it last week shortly after creating this PR @JasonLunn. NVM, just found the refresh link.

NathanBaulch avatar Aug 05 '24 21:08 NathanBaulch

Sorry @JasonLunn, I force pushed to resolve a new conflict with main and lost the "safe for tests" status.

NathanBaulch avatar Aug 09 '24 11:08 NathanBaulch

Bump!

NathanBaulch avatar Sep 03 '24 11:09 NathanBaulch

Hi Nathan, sorry for the late response, unfortunately it looks like there are new merge conflicts from some of the files going stale. Could you pull up to main and resolve the merge conflicts please?

tonyliaoss avatar Sep 20 '24 16:09 tonyliaoss

Hi Nathan,

We are going to do a force-pull and resolve those conflicts ourselves. No action needed on your part.

tonyliaoss avatar Sep 20 '24 18:09 tonyliaoss

No worries @tonyliaoss, let me know if you need anything.

NathanBaulch avatar Sep 20 '24 20:09 NathanBaulch