protobuf icon indicating copy to clipboard operation
protobuf copied to clipboard

Add bootstrap build for upb

Open owent opened this issue 1 year ago • 3 comments

Fixes #15111 Fixes #13751

owent avatar Dec 15 '23 19:12 owent

Thank you for this submission, it's clear you put a fair amount of effort into this and we appreciate it. Unfortunately we are already working on fixing the cmake support for upb in a way which ties it much more strongly to the existing protobuf cmake support.

ericsalo avatar Dec 21 '23 20:12 ericsalo

Thank you for this submission, it's clear you put a fair amount of effort into this and we appreciate it. Unfortunately we are already working on fixing the cmake support for upb in a way which ties it much more strongly to the existing protobuf cmake support.

Thank you, I have been eagerly awaiting this for months. Prior to the completion of this implementation, we have an internal patch to bootstrap build upb with Lua binding, and we also use gRPC (which depends on upb). However, the make_cmakelists.py has undergone significant changes in recent months, requiring us to repeatedly rework the patch. Therefore, I am wondering if we could use a temporary solution until the final implementation is completed.

owent avatar Dec 22 '23 02:12 owent

@ericsalo any news ?

calvin2021y avatar Feb 15 '24 10:02 calvin2021y

We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active, please add a comment.

This PR is labeled inactive because the last activity was over 90 days ago. This PR will be closed and archived after 14 additional days without activity.

github-actions[bot] avatar May 16 '24 10:05 github-actions[bot]

We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active or becomes active again, please reopen it.

This PR was closed and archived because there has been no new activity in the 14 days since the inactive label was added.

github-actions[bot] avatar May 30 '24 10:05 github-actions[bot]