protobuf icon indicating copy to clipboard operation
protobuf copied to clipboard

Migrate to Bzlmod for managing external dependencies

Open meteorcloudy opened this issue 2 years ago • 6 comments

With future Bazel LTS versions, Bzlmod will become the default system for external dependencies management.

Please consider migrating all your external dependencies in WORKSPACE to MODULE.bazel

For more information, please check https://github.com/bazelbuild/bazel/issues/18958

Related issue is https://github.com/protocolbuffers/protobuf/issues/13618, but #13618 is more about providing a Bazel modules for users, this one is for tracking the migration of protobuf itself to use Bzlmod for managing both prod and dev external deps.

meteorcloudy avatar Oct 06 '23 13:10 meteorcloudy

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

github-actions[bot] avatar Jan 24 '24 10:01 github-actions[bot]

ping, to keep it active

meteorcloudy avatar Jan 24 '24 10:01 meteorcloudy

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

github-actions[bot] avatar Apr 25 '24 10:04 github-actions[bot]

.

aaliddell avatar Apr 25 '24 20:04 aaliddell

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago. This issue will be closed and archived after 14 additional days without activity.

github-actions[bot] avatar Jul 25 '24 10:07 github-actions[bot]

.

ianb-pomelo avatar Jul 25 '24 15:07 ianb-pomelo

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago. This issue will be closed and archived after 14 additional days without activity.

github-actions[bot] avatar Dec 12 '24 10:12 github-actions[bot]

This is still active and will help downstream migration to BZLMOD

ianb-pomelo avatar Dec 12 '24 18:12 ianb-pomelo

Should be able to close this with the addition of MODULE.bazel since ~v27.x. See https://github.com/bazelbuild/bazel-central-registry/tree/main/modules/protobuf.

Please reopen (or file a new issue) for any dependencies missing in bzlmod.

zhangskz avatar Dec 16 '24 21:12 zhangskz

Protobuf still use workspace as default, please edit the issue description to "Add support to bzlmod" OR reopen this issue until Protobuf default to bzlmod...

src: https://github.com/protocolbuffers/protobuf/blob/233098326bc268fc03b28725c941519fc77703e6/.bazelrc#L31-L33 note: (same on v29.2 or today's main)

PS: Could be also good to label properly this issue and also use "milestone" with a version ? (so downstream google project like google/or-tools or pybind/pybind11_protobuf can easily track and follow your roadmap...)

Mizux avatar Dec 20 '24 09:12 Mizux