protocolbuffers
Public the MergeFrom method of type ReadOnlySequence<byte>
(Edited by jskeet) For public release notes:
Add a public IMessage.MergeFrom(ReadOnlySequence<byte>) extension method, exposing existing internal functionality.
(Parsing a completely new message from ReadOnlySequence<byte> was already publicly available, just not merging.)
Public the MergeFrom method of type ReadOnlySequence<byte>.
We found that the MergeFrom method of type ReadOnlySequence<byte> is internal.
We need it !!!
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
![google-cla[bot] avatar](https://avatars.githubusercontent.com/in/42202?v=4 "Published by a pub.dev verified publisher"){kind=small}
I'll need to carefully consider the impact of this on various versions etc. I'm still finishing up work from going on vacation, so I won't even be able to look at this until January. It may not make it into the next version; we'll see.
Right, I've now had a better chance to evaluate this, and it looks fine. I've edited the PR description so that it'll be easier to create release notes.
@deannagarcia: This should be included in the next C# release. I'm happy for it to either stay here as a PR and get included via Copybara when that work is complete, or force-merged now. Let me know what you think.
@deannagarcia: I may well be able to do that myself. Will give it a try.
Thanks for @jskeet 's help. :)
I'm going to rebase and repush this PR so that it has a recent HEAD - I believe that we'll then be able to get this merged.