protobuf icon indicating copy to clipboard operation
protobuf copied to clipboard

editorconfig integration

Open Asalle opened this issue 5 years ago • 3 comments

What language does this apply to? protobuf.el

Describe the problem you are trying to solve. protobuf-mode ignores the settings in .editorconfig of my project. The project contains only .proto files and a couple of bash scripts. I set indent_style = tab in .editorconfig and it works well for other files, but .proto files are still indented with 2 spaces.

Describe the solution you'd like After setting indent_style = tab in .editorconfig I would expect .proto files to be also indented with tabs.

Describe alternatives you've considered I tried to follow instructions mentioned here. Didn't succeed, it would be much nicer if the desired behaviour would be picked up from .editorconfig or at least there would be a var for indent style.

Additional context Add any other context or screenshots about the feature request here.

Asalle avatar Nov 12 '19 13:11 Asalle

@TeBoring @acozzette

I'm not sure if anyone from our team knows much about that config, but if you can figure out the problem then please free to send a pull request to us :)

rafi-kamal avatar Nov 13 '19 00:11 rafi-kamal

Google style is to always use spaces, never tabs. I'm not sure we should allow this.

https://developers.google.com/protocol-buffers/docs/style

elharo avatar Sep 15 '21 12:09 elharo

The EBNF grammar seems unclear on this point. That is, I don't know whether tabs are allowed in .proto files or not.

elharo avatar Sep 15 '21 13:09 elharo

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

github-actions[bot] avatar Mar 31 '24 10:03 github-actions[bot]

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please reopen it.

This issue was closed and archived because there has been no new activity in the 14 days since the inactive label was added.

github-actions[bot] avatar Apr 15 '24 10:04 github-actions[bot]