protobuf icon indicating copy to clipboard operation
protobuf copied to clipboard

Allow PHP reserved words as valid constant names

Open bshaffer opened this issue 3 years ago • 5 comments

As of PHP 7.0, all the reserved words listed in kReservedNames are now allowed (and can also be added to kValidConstantNames) with the exception of "class". Although it'd probably be better to refactor the list to be kReservedConstantNames with just "class".

As the latest version of protobuf for PHP now supports a minimum of 7.0, we can open up these words. As changing these would break backwards compatibility, it would be better to target a future major version of protobuf for PHP with this change.

bshaffer avatar Jul 28 '22 20:07 bshaffer

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

github-actions[bot] avatar Jan 07 '24 10:01 github-actions[bot]

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please reopen it.

This issue was closed and archived because there has been no new activity in the 14 days since the inactive label was added.

github-actions[bot] avatar Jan 22 '24 10:01 github-actions[bot]

This is still a valid (and important) change that should be made

bshaffer avatar Jan 22 '24 16:01 bshaffer

Reopened. Please feel free to submit a PR for this.

haberman avatar Feb 08 '24 00:02 haberman

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

github-actions[bot] avatar May 13 '24 10:05 github-actions[bot]

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please reopen it.

This issue was closed and archived because there has been no new activity in the 14 days since the inactive label was added.

github-actions[bot] avatar May 28 '24 10:05 github-actions[bot]