protocolbuffers
Adding snupkg support
Create separate .symbols.nupkg package for debugging C# code instead of .pdb files.
Requested in #6218
I'm on holiday until Monday so don't have a chance to review until then - although personally I tend to prefer having everything in a single package file.
There are definitely pros and cons here. Personally I still prefer having the PDB files in the package - that way all the information you need for debugging is right there, without any connection needed to talk to Microsoft servers. The scenario of company package repositories unpacking and then repacking a package is one I hadn't come across before though. (And my immediate reaction is "ewww" - but that doesn't help developers stuck in that situation, of course.)
It does look like snupkg files are more widely used though, so maybe we should do this. @jtattermusch noted a preference for retaining PDB files before - Jan, is your opinion the same as it was, or has working on Grpc.Net.Client changed your mind?
I will definitely go with your opinions here, but thought it was worth at least having the conversation based on requests
There are definitely pros and cons here. Personally I still prefer having the PDB files in the package - that way all the information you need for debugging is right there, without any connection needed to talk to Microsoft servers. The scenario of company package repositories unpacking and then repacking a package is one I hadn't come across before though. (And my immediate reaction is "ewww" - but that doesn't help developers stuck in that situation, of course.)
It does look like snupkg files are more widely used though, so maybe we should do this. @jtattermusch noted a preference for retaining PDB files before - Jan, is your opinion the same as it was, or has working on Grpc.Net.Client changed your mind?
My opinion hasn't changed.
My opinion hasn't changed.
In that case, I'd suggest closing this PR and adding a note to #6218. I wouldn't close that issue though - I think it's worth keeping open for occasional re-evaluation, partly to see whether we get additional comments from other customers.
Not yet. It looks like there are currently some issues debugging into nuget packages. I haven't had time to get to the bottom of it yet, but we may end up wanting to do this after all.
Not yet. It looks like there are currently some issues debugging into nuget packages. I haven't had time to get to the bottom of it yet, but we may end up wanting to do this after all.
I looked into this for other libraries, and there were some Visual Studio / build issues that were apparently causing the problem.
They're fairly simple to work around in most cases though, and I'd still rather not publish the snupkg files. See https://cloud.google.com/dotnet/docs/reference/help/troubleshooting#how-can-i-debug-into-the-libraries for the workaround - and with that in place, I'm going to close this PR.