protobuf-javascript icon indicating copy to clipboard operation
protobuf-javascript copied to clipboard

added minimal support for es6 import_style

Open safanaj opened this issue 2 years ago • 4 comments

Due to our limited support resources, we are focusing our attention on small bug fixes that have limited compatibility concerns. Most other PRs will be rejected.


This PR is small in size and is dding a minimal support (probably/mostly) not full neither complete for es6 import style.

safanaj avatar Nov 05 '22 18:11 safanaj

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Nov 05 '22 18:11 google-cla[bot]

I tried it on a project using vite and having a lot of protocolbuffers messages and it works great, thank you safranaj !

PicoI2 avatar Dec 07 '23 10:12 PicoI2

@lukesandberg any chances to make some progress on this? With modern approach with esbuild + vite it's also impossible to use google-protobuf

wszydlak avatar Mar 26 '24 14:03 wszydlak

Can anybody make a code review?

stasberkov avatar May 13 '24 21:05 stasberkov