protobuf.js icon indicating copy to clipboard operation
protobuf.js copied to clipboard

fix: remove eval usage so that chrome extension MV3 can run properly

Open AntiMoron opened this issue 2 years ago • 16 comments

AS POST TITLE.

I think this can be published as an alpha version for more tests.

AntiMoron avatar Oct 09 '23 09:10 AntiMoron

The latest Chrome(currently 118.0.5993.117) is blocking js that contains 'eval' now, which may result in blank screen.

image

AntiMoron avatar Oct 31 '23 06:10 AntiMoron

Sorry for disturbing. I'm willing to push the progress.

@dcodeIO @alexander-fenster @bcoe

AntiMoron avatar Oct 31 '23 06:10 AntiMoron

Let's see how ChatGPT judge it:

image

image

image

AntiMoron avatar Oct 31 '23 09:10 AntiMoron

Helo, @AntiMoron do you have any updates on this issue? @dcodeIO @alexander-fenster @bcoe do you plan to move this forward? Thank you!

butoramatus avatar Nov 09 '23 11:11 butoramatus

Helo, @AntiMoron do you have any updates on this issue? @dcodeIO @alexander-fenster @bcoe do you plan to move this forward? Thank you!

No, I think I've done the coding & testing part, now I'm looking for core members to merge. Thanks for supporting!

AntiMoron avatar Nov 10 '23 13:11 AntiMoron

Hi, is there anything what we can do to fix this issue/ merge this request? It starts to become a real issue for us.

Thanks!

TvojTatk0 avatar Nov 20 '23 11:11 TvojTatk0

Hi, it has been a month since the code commited. The code has been thoroughly reviewed and is clean and easy to verify. I kindly request your attention to address this matter at your earliest convenience.

Jennal avatar Nov 20 '23 13:11 Jennal

anyone with write access spend sometime on reviewing this? @dcodeIO @robin-anil @murgatroid99 @JustinBeckwith

AntiMoron avatar Nov 21 '23 03:11 AntiMoron

Update on this one?

emillime avatar Dec 19 '23 12:12 emillime

Update on this one?

Sadly, still waiting for someone to review this.

AntiMoron avatar Jan 10 '24 08:01 AntiMoron

Still waiting on this!!

LivingstonPradeep avatar Feb 15 '24 19:02 LivingstonPradeep

any updates here?

graham-atom avatar May 14 '24 20:05 graham-atom

@alexander-fenster

graham-atom avatar May 14 '24 20:05 graham-atom

any updates ??

zhanzekun avatar May 22 '24 16:05 zhanzekun

I'm going to fork it, I can't stand it anymore. The repository owner seems unwilling to accept any changes, right?

zhanzekun avatar May 22 '24 16:05 zhanzekun

@zhangzekun I think so.

@dcodeIO He's just there. No offense, I just checked his profile, yes, he's been commiting constantly during past months.

image

This fix should be fine, please merge and pub an alpha version?

AntiMoron avatar May 23 '24 02:05 AntiMoron