protobuf.js icon indicating copy to clipboard operation
protobuf.js copied to clipboard

Published 20 hours ago • verified publisher icon protobufjs

Fix nullability of non-optional fields in TS interfaces and class-level JS comments

Open martin-traverse opened this issue 2 years ago • 5 comments

martin-traverse avatar Jul 27 '22 12:07 martin-traverse

Relevant issue is #1779

martin-traverse avatar Jul 27 '22 12:07 martin-traverse

Hey, would you have ETA for when this will be merged please?

mamiksik avatar Apr 20 '23 10:04 mamiksik

Hello, any chance to see this merged?

andrea11 avatar May 23 '23 06:05 andrea11

Hello - I have rebased this PR on top of the latest master. Also as per #1779, the change is hidden behind a new flag --pb3-optional. If the flag is not specified, the old behaviour is retained.

@alexander-fenster - are you happy to merge with these changes? Let me know if there is anything else you think would be helpful. We're coming up to the next release series of our product, so for us it would be great to have this in time for that release.

martin-traverse avatar May 26 '23 09:05 martin-traverse