protobuf.js icon indicating copy to clipboard operation
protobuf.js copied to clipboard

Published 20 hours ago • verified publisher icon protobufjs

Fix blocker jsdoc bugs

Open buu700 opened this issue 1 year ago • 2 comments

These are major happy path bugs that have been in the stable release for a number of years now. The root cause seems to be on jsdoc's end, but the ticket remains unaddressed.

At this point, I think it makes sense to just stick with 3.5.5 indefinitely, at least until jsdoc is fixed and updated to provide a cleaner interface.

buu700 avatar Jul 19 '22 02:07 buu700

Do you think we could leave the fix in pbts code, but avoid pinning jsdoc?

alexander-fenster avatar Aug 17 '22 18:08 alexander-fenster

I'm not really sure. This is the fix that worked for me, but I'm not familiar enough with protobufjs or jsdoc to say what it would take to work around the issue without pinning.

This has been broken for several years now, but the jsdoc team hasn't been responding to the issue I'd submitted (https://github.com/jsdoc/jsdoc/issues/1644).

buu700 avatar Aug 17 '22 18:08 buu700

Closed because it's superseded by #1844.

buu700 avatar Jan 06 '23 18:01 buu700