Fix SST parsing when SST XML has a tag prefix

[mbarzda]

XLSX documents written by DocumentFormat.OpenXml.dll (at least sometimes) contain a tag prefix "x" in the sharedStrings.xml file. This is a fix to the regular expressions that parse this file to handle the prefix if it is present. https://github.com/SheetJS/js-xlsx/pull/271

[protobi]

Thanks! I see you've made changes to the bits directly which is great. I also see that you've run the test suite, also great.

There's a commit note that certain tests are excluded. Being unable to running the complete test suite on Node 4+ has been the time bottleneck I've been meaning to get to to. Identifying/removing tests specific to node 4 might a good pragmatic alternative to porting over the XLS and XLSB formats. What version of Node do the tests run on?

Pieter

On Thu, Oct 6, 2016 at 9:57 AM, Martynas Barzda [email protected] wrote:

XLSX documents written by DocumentFormat.OpenXml.dll (at least sometimes) contain a tag prefix "x" in the sharedStrings.xml file. This is a fix to the regular expressions that parse this file to handle the prefix if it is

present. SheetJS#271 https://github.com/SheetJS/js-xlsx/pull/271

You can view, comment on, or merge this pull request online at:

https://github.com/protobi/js-xlsx/pull/47 Commit Summary

• fixed regular expressions https://github.com/SheetJS/js-xlsx/pull/271
• Merge pull request #1 from mbarzda/bugfix/cannot_parse_prefixed_tags
• exclude failing misc tests

File Changes

• M bits/01_version.js https://github.com/protobi/js-xlsx/pull/47/files#diff-0 (2)
• M bits/42_sstxml.js https://github.com/protobi/js-xlsx/pull/47/files#diff-1 (12)
• M dist/xlsx.core.min.js https://github.com/protobi/js-xlsx/pull/47/files#diff-2 (25)
• M dist/xlsx.core.min.map https://github.com/protobi/js-xlsx/pull/47/files#diff-3 (2)
• M dist/xlsx.full.min.js https://github.com/protobi/js-xlsx/pull/47/files#diff-4 (32)
• M dist/xlsx.full.min.map https://github.com/protobi/js-xlsx/pull/47/files#diff-5 (2)
• M dist/xlsx.js https://github.com/protobi/js-xlsx/pull/47/files#diff-6 (24)
• M dist/xlsx.min.js https://github.com/protobi/js-xlsx/pull/47/files#diff-7 (25)
• M dist/xlsx.min.map https://github.com/protobi/js-xlsx/pull/47/files#diff-8 (2)
• M test.js https://github.com/protobi/js-xlsx/pull/47/files#diff-9 (14)
• M xlsx.js https://github.com/protobi/js-xlsx/pull/47/files#diff-10 (14)

Patch Links:

• https://github.com/protobi/js-xlsx/pull/47.patch
• https://github.com/protobi/js-xlsx/pull/47.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/protobi/js-xlsx/pull/47, or mute the thread https://github.com/notifications/unsubscribe-auth/ABRm1a8Oa7W-Et2kfsI42mWvqYDL37nCks5qxP5VgaJpZM4KP-Nw .

[mbarzda]

Hi, general tests (make test) are still failing, but misc tests work with skips. I runned tests on Node v5.10.1