swrltab-plugin icon indicating copy to clipboard operation
swrltab-plugin copied to clipboard

The Rule Editor interface is slightly confusing

Open matthewhorridge opened this issue 9 years ago • 8 comments

I expected the field labelled "Rule" to be the place to enter the rule. I wondered why auto-completion wasn't working! Perhaps "Rule name" would be clearer.

Also, I would label the editor - I thought it was the status window. I would put the status window below the editor.

Finally, the look and feel is odd - it's not using the Protege look and feel components.

swrltab

matthewhorridge avatar Feb 14 '16 22:02 matthewhorridge

The name and status things makes sense.

As for look and feel, unless this is easy to do I don't think I will have the cycles to do this anytime soon. Do you have pointers to the relevant Protege classes?

martinjoconnor avatar Feb 14 '16 22:02 martinjoconnor

Regarding the look and feel, this should just work without any extra settings or fiddling. Are you using some special components or just a regular JTextField etc.

matthewhorridge avatar Feb 14 '16 22:02 matthewhorridge

Everything is plain vanilla Swing.

martinjoconnor avatar Feb 14 '16 23:02 martinjoconnor

The only Protege-specific UI classes are the plugin wrapping code.

martinjoconnor avatar Feb 14 '16 23:02 martinjoconnor

o.k. is the dialog instantiated as needed or is it held in a static field? I'm guessing it gets instantiated before the Look and Feel stuff is set in the Protege initialiser.

matthewhorridge avatar Feb 14 '16 23:02 matthewhorridge

For some reason, it is not created on demand. However, changing it so that it is created on demand is easy.

martinjoconnor avatar Feb 14 '16 23:02 martinjoconnor

o.k. cool.... or at least lazily created (I think this would suffice)

matthewhorridge avatar Feb 14 '16 23:02 matthewhorridge

It looks like the feedback on the Rule/Name has been addressed

Screen Shot 2021-11-07 at 10 21 56 AM

ThomasThelen avatar Nov 07 '21 18:11 ThomasThelen