protege-client icon indicating copy to clipboard operation
protege-client copied to clipboard

Simpler error message dialog

Open johardi opened this issue 9 years ago • 5 comments

The error dialog is too verbose for an end-user. screen shot 2016-07-28 at 2 46 27 pm

johardi avatar Jul 29 '16 00:07 johardi

Does this only happen in the Server Admin UI? In that tab it was by design - only admins use the admin tab, so I reckoned they should be Ok seeing the full stack trace :) But if one of these dialogs slipped into the diff tab I'll modify. Did you spot any?

rsgoncalves avatar Jul 29 '16 02:07 rsgoncalves

I still see lengthy stacks in LogDiff:findBaselineMatches occasionally when bad data causes null pointers

bdionne avatar Jul 29 '16 10:07 bdionne

I'd still recommend to use a simpler error dialog to an end-user, including to the admin. I've made a feature request ticket in Protege to have the error dialog be able to collapse or expand the error details (Ref: https://github.com/protegeproject/protege/issues/487). Hope this would fit better.

johardi avatar Jul 29 '16 16:07 johardi

@bdionne could you post the steps to replicate those NPEs?

rsgoncalves avatar Aug 02 '16 17:08 rsgoncalves

The NPEs in LogDiff:findBaselineMatches are detailed here. I can't recall the exact steps, but I was able to somehow create bad data, an annotation change with a null property. You can see in LogDiff:findBaselineMatches where that would cause problems. Not sure whether it's worth putting in defensive code for it or not. I'll keep my eye out for it

bdionne avatar Aug 03 '16 17:08 bdionne