Sass errors on division and max-width: null

[jonathanstegall]

I'm starting an early attempt to upgrade our implementation of Column Setter to v2. I tried copying in the new versions without changing anything else just to see what would happen:

Deprecated / for division

Sass doesn't allow using / to divide anymore, but they do have some good resources, including an automatic upgrader.

npm install -g sass-migrator
sass-migrator division **/*.scss

As far as I can tell, running these commands on Column Setter works fine.

Invalid max-width

I've previously had $max-width: null; in my settings, as shown in the example. In v2, this causes this error:

Warning: $max-width's value ('') in _column-settings.scss is invalid. It must be a number with a unit. Learn more: https://github.com/propublica/column-setter

When I change it to $max-width: 80em; the error goes away and the CSS compiles without complaint. I haven't gone through to see what design implications this might have for us, but I thought you might want to change the docs if $max-width: null; is no longer supported.

[robweychert]

@jonathanstegall Thanks for the heads up! I’ll look into these issues.