fury-old icon indicating copy to clipboard operation
fury-old copied to clipboard

Building a nonexistent module with a slash in the name triggers build of the selected module

Open odisseus opened this issue 5 years ago • 5 comments

$ fury -m foobar
The module has not been specified.

$ fury -m foo-bar
The module has not been specified.

$ fury -m foo/bar --output linear
Starting compilation of module fury/io
Successfully compiled module fury/io
...
Starting compilation of module fury/frontend
Successfully compiled module fury/frontend
Starting compilation of module fury/project
Successfully compiled module fury/project

$ fury -m / --output linear
Starting compilation of module fury/io
Successfully compiled module fury/io
...
Starting compilation of module fury/frontend
Successfully compiled module fury/frontend

odisseus avatar Feb 20 '20 14:02 odisseus

The same issue appears for building projects. Will try to fix it as well.

szymon-rd avatar Mar 05 '20 09:03 szymon-rd

Actually, PR was closed not merged, reopening issue due to my mistake.

szymon-rd avatar Mar 08 '20 14:03 szymon-rd

The error message does not appear if the wrong module name contains a slash, like foo/bar.

odisseus avatar Mar 17 '20 13:03 odisseus

This issue returned after PR #1223 was merged. Every kind of problem with the module name argument is now treated as if that argument were missing, and the default module is substituted.

odisseus avatar Apr 14 '20 15:04 odisseus

PR #1282 has brought this issue back again. I see a pattern here...

odisseus avatar May 04 '20 14:05 odisseus