PropelBundle icon indicating copy to clipboard operation
PropelBundle copied to clipboard

Published 20 hours ago • verified publisher icon propelorm

Symfony 4 Compatibility

Open ilohpro opened this issue 7 years ago • 6 comments

ilohpro avatar Nov 18 '17 14:11 ilohpro

Please, could you re-run travis? After merging https://github.com/propelorm/Propel2/pull/1434 test suite should be green. Thank you!

cristianoc72 avatar Jan 10 '18 13:01 cristianoc72

My last commit is green, I left you see if it's usefull to merge it to the master...

ilohpro avatar Jan 27 '18 22:01 ilohpro

Thank you to include my branch 4.0 into your PR! Anyway, I'm asking you (and the PropelBundle team) to consider the following points:

  1. I refactored the bundle to be Symfony 4.0 only, so it's better to create a new 4.0 branch in Propel repository, instead of merging it into 3.0, because it beaks compatibility with Symfony 3.
  2. My 4.0 branch is not finished yet: I have to test the commands behavior with the new directory structure and some configuration properties should be moved from configuration file to .ENV file. I plan to do this in a couple of days.
  3. Since Symfony 4 directory structure is different from previous versions, there are some changes in PropelBundle 4.0 branch that should be documented. I plan to write a new recipe for Propel cookbook at the end of the next week.
  4. Last but not the least, I'm working on a Symfony flex recipe for PropelBundle, so that we could install PropelBundle and Propel simply with composer require propel.

Please, have a little patience again 😄

cristianoc72 avatar Jan 28 '18 15:01 cristianoc72

I too have been working on a 4.0 branch for this. Please feel free to use any of my work on this. I have implemented registering of the commands, and have tested most of them. My unit tests all come back green. One of my concerns of your current work is setting all of the services to be public, which isn't considered best practices within symfony. Also your changes in Command/AbstractCommand.php are unnecessary if files are placed in the proper place (schemas will be found and moved to the cache if placed in src/propel/*schema.xml).

kingchills avatar Feb 02 '18 18:02 kingchills

@kingchills your work is almost perfect, and it's compatible with Symfony 3.4, too! Why don't you submit a PR? Imho, your 4.0 branch is already mergeable, as is.

cristianoc72 avatar Feb 05 '18 08:02 cristianoc72

@cristianoc72 Consider it done.

kingchills avatar Feb 05 '18 14:02 kingchills

Shall we continue here?

dereuromark avatar Nov 21 '22 11:11 dereuromark

It's quite old, I think this pull request has to been fully reviewed on new versions. Personnally, i don't use it anymore, maybe i should close this PR too.

ilohpro avatar Nov 21 '22 11:11 ilohpro

Actually, https://github.com/SkyFoxvn/PropelBundle will most likely be the follower of this now.

dereuromark avatar Nov 21 '22 11:11 dereuromark