PropelBundle icon indicating copy to clipboard operation
PropelBundle copied to clipboard

Deprecated function usages

Open gharlan opened this issue 10 years ago • 7 comments

There are some deprecated (since SF 2.7) function usages which should be fixed.

Examples:

screenshot 2015-08-05 16 46 02

gharlan avatar Aug 05 '15 14:08 gharlan

Would it be ok to bump the symfony min version from 2.5 to 2.7? 2.5 is dead, and 2.6 is in "security fixes only" mode and will be dead from 01/2016.

The fixes would be simpler.

gharlan avatar Aug 06 '15 08:08 gharlan

Is there any technical reason for the required changes (didn't have a look at them by now) to raise the dependency version?

I'm against it, as there are probably applications out there, which do not require 2.7. Which is fine, if they don't have needs for it. So if this bundle does not require 2.7, we are not in charge or responsibility to raise the dependency for any application using this bundle.

havvg avatar Aug 06 '15 11:08 havvg

There are symfony 2.8, in witch forms do no work. There is symfony 3.0, witch can't be installed because of composer requirements.

angelk avatar Dec 02 '15 21:12 angelk

I'm on the current move:

There is a new branch 1.5 which raises the dependency to Symfony 2.8, which is the current LTS. I gave it a lot of thoughts, and this step is fine, we commit on an LTS and this will be easier to support on a new branch, while leaving the old branches. The old ones will only receive an update on the incompatibility of their respective Symfony versions.

The second branch (not created yet) will be 1.6, which will be Symfony 3.0 compatible, but 2.8 incompatible.

havvg avatar Jan 22 '16 19:01 havvg

The former Propel1 bridge of the symfony package has been merged. In case you are still up to it, the 1.5 branch is ready for the changes.

The distributed phpunit.xml.dist disables the deprecation errors, you have to change the error level.

havvg avatar Jan 23 '16 16:01 havvg

@havvg I forgot to mention in my initial post that I'm talking about the propel 2.x version. What should be the min symfony version for 2.x branch?

gharlan avatar Feb 10 '16 21:02 gharlan

@gharlan I would suggest ^2.8|^3.0, being ready for upcoming 3.4 LTS.

havvg avatar Feb 11 '16 16:02 havvg