use parent:: instead of ModelCritera::
As recommended in php docs http://php.adamharvey.name/manual/en/keyword.parent.php
#2009
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.97%. Comparing base (
3417fea) to head (2951a74). Report is 4 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:exclamation: There is a different number of reports uploaded between BASE (3417fea) and HEAD (2951a74). Click for more details.
HEAD has 3 uploads less than BASE
Flag BASE (3417fea) HEAD (2951a74) 7.4 4 3 5-max 4 3 agnostic 1 0
Additional details and impacted files
@@ Coverage Diff @@
## master #2016 +/- ##
=============================================
- Coverage 89.25% 73.97% -15.28%
Complexity 8065 8065
=============================================
Files 232 232
Lines 24550 24550
=============================================
- Hits 21911 18161 -3750
- Misses 2639 6389 +3750
| Flag | Coverage Δ | |
|---|---|---|
| 5-max | 73.97% <ø> (-15.28%) |
:arrow_down: |
| 7.4 | 73.97% <ø> (-15.28%) |
:arrow_down: |
| agnostic | ? |
|
| mysql | 69.79% <ø> (-0.02%) |
:arrow_down: |
| pgsql | 69.84% <ø> (ø) |
|
| sqlite | 67.79% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@rizwanjiwan would you be willing to reopen this PR? The single change to Propel\Generator\Builder\Om\QueryBuilder seems useful.
If so, please rebase on master and remove the other changes. CI will now run the testsuite correctly so hopefully we can merge it afterwards.
Thank you!