fix column names in versionable with Postgres

Open kcivey opened this issue 12 years ago • 5 comments

When using Postgres, the versionable behavior produces invalid column names for the *_ids and *_versions columns, because the foreign table name it uses as a prefix includes the Postgres schema name and a dot. This pull request uses getCommonName() instead of getName() for the table name when generating the column names, thus leaving off the schema prefix.

This replaces the pull request submitted a while back as #498.

May 22 '13 04:05 kcivey

could you add a testcase which fails without your patch?

May 22 '13 07:05 staabm

well yeah, a test case would be nice.

May 22 '13 08:05 willdurand

ping @kcivey

May 29 '13 07:05 willdurand

Sorry, I haven't had time to figure out the testing yet. It looks like the Versionable tests all use a SQLite database, but I guess I can stick a Versionable test into the Postgres testing.

May 29 '13 13:05 kcivey

Has this issue been fixed?

Aug 17 '15 16:08 tacman