Propel
Propel copied to clipboard
propelorm
Migration to PHP 7.4
A lot of small changes applied to ensure that code works with PHP7.4, any help and thoughts are highly appreciated.
The support for PHP 7.4 is very welcome - thank you for doing this!
But from what I can see, this approach breaks the support for older versions of PHP. Perhaps this only makes sense as a separate branch?
Does anyone know of a reliable fork that completely fixes php 7.4 compatibility without breaking compatibility with 5.x (or introducing lots of regressions)?
Right now the most disastrous bc-breaking change in PHP 7.4 that I'm observing that completely breaks Propel 1 is this: https://www.php.net/manual/en/migration74.incompatible.php#migration74.incompatible.spl
This does NOT fix compatibility with PHP 7.4.
With 7.3 maybe, but this does not address https://www.php.net/manual/en/migration74.incompatible.php#migration74.incompatible.spl
May it be merged as a separate version? For my case its not relevant at all to have php 5.x support . I am not going to get back to it, but project is too big, and upgrading to propel2 is another big change that I am not ready yet.
@teo1978 Tests for 7.4 are passing and I must admit this fork is running fine on a commercial project for almost a year without issues. We are doing a slow migration to Doctrine in the meantime.
I am planning to start migrating it towards 8.0 this month.
Any news with regard to 8.0 support? I might consider helping out as I have a project running on propel as well.
We've been using @tworzenieweb changes for supporting for PHP 7.4 for a long while now and haven't had any issues. 👍
@tworzenieweb Did you do any progress on the support for PHP 8.0 since then? I might give a hand towards that if I find the time, but would be best to avoid duplicate work.
@tworzenieweb Thanks for your work on this! We used this as the basis for our fork with PHP 8.0 support.
@mentalstring @DanielFortuyn We published https://packagist.org/packages/dayspring-tech/propel-bundle#1.8.0 as a drop-in replacement with PHP 8.0 compatibility.
