proot icon indicating copy to clipboard operation
proot copied to clipboard

SYSARG_1 and SYSARG_RESULT are the same on ARM and AArch64

Open yuyichao opened this issue 2 years ago • 3 comments

And I assume this is a problem on sh4 as well for SYSARG_5 and SYSARG_RESULT.

This cause the syscall exit handler to get the wrong arg1 value, in particular, for PR_getsockname. This causes the socket03 test to fail.

A similar issue exists on x86 between SYSARG_NUM and SYSARG_RESULT but the user_regs_struct have a orig_eax/orig_rax there that stored the old value.

yuyichao avatar Sep 30 '21 13:09 yuyichao

@yuyichao is this fixed with the latest v5.3.0 release?

oxr463 avatar Jan 22 '22 16:01 oxr463

The linked PR worked around this for the specific case. I didn’t see any built in use that can cause problem but I also don’t think there’s a generic solution atm.

yuyichao avatar Jan 22 '22 16:01 yuyichao

Hmm, okay. I'll leave this open for now then.

oxr463 avatar Jan 22 '22 17:01 oxr463