event-store-client icon indicating copy to clipboard operation
event-store-client copied to clipboard

StopWatch in seconds + VNodeState string backed enum

Open grymmare opened this issue 2 years ago • 3 comments
trafficstars

  1. Connecting to a cluster does not work, the node state returned from the server is a string, so either we need VNodeState to be a string backed enum (as suggested in this PR) or a custom factory needs to be created, if keeping the integers is important.

  2. In the new amp v3 version, timeouts/intervals in the connection settings are configured in seconds (floats) rather than milliseconds. This PR changes the stopwatch to return a float (in seconds) instead of an int (in milliseconds)

grymmare avatar Oct 02 '23 13:10 grymmare

Sorry for my late reply. What's the reason for the changes on VNodeState? I don't get it.

prolic avatar Feb 13 '24 22:02 prolic

MemberInfoDto does VNodeState::from($value), where $value is a string. MemberInfoDto is created by ClusterDnsEndPointDiscoverer::tryGetGossipFrom(). Without the backed enum it failed to construct.

I'm using eventstore 23.10, but I believe at the time I was at 22.10.

grymmare avatar Feb 13 '24 22:02 grymmare

Thanks for the information provided. I will look into it.

On Tue, Feb 13, 2024, 19:22 Marcus Grymmare @.***> wrote:

MemberInfoDto does VNodeState::from($value), where $value is a string. MemberInfoDto is created by ClusterDnsEndPointDiscoverer::tryGetGossipFrom(). Without the backed enum it failed to construct.

I'm using eventstore 23.10, but I believe at the time I was at 22.10.

— Reply to this email directly, view it on GitHub https://github.com/prooph/event-store-client/pull/170#issuecomment-1942737459, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADAJPHK5GZL2U3AL76CAA3YTPRRLAVCNFSM6AAAAAA5PNYZYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBSG4ZTONBVHE . You are receiving this because you commented.Message ID: @.***>

prolic avatar Feb 13 '24 22:02 prolic

Thanks, sorry for the delay.

prolic avatar Jun 11 '24 22:06 prolic