event-store-client icon indicating copy to clipboard operation
event-store-client copied to clipboard

Published 20 hours ago • verified publisher icon prooph

Travis failed (ramsey uuid 4)

Open prolic opened this issue 5 years ago • 9 comments
trafficstars

prolic avatar May 02 '20 04:05 prolic

see https://github.com/ramsey/uuid/issues/314

prolic avatar May 02 '20 04:05 prolic

I reverted the PR that allowed v4 for now, see https://github.com/prooph/event-store/pull/396

prolic avatar May 02 '20 04:05 prolic

I assume this can be closed then?

Nek- avatar May 02 '20 16:05 Nek-

Let's leave it open until we hear back from ramsey.

prolic avatar May 02 '20 19:05 prolic

@prolic why did you close this? I don't think it's fixed

enumag avatar Jul 13 '22 05:07 enumag

It's two years now and it seems like ramsey's uuid (at least v4) won't get fixed. In case it changes in an upcoming v5 release, we can re-address this.

prolic avatar Jul 14 '22 15:07 prolic

Then I think we should try to remove dependency on ramsey/uuid completely. It's widely used so the incompatibility with v4 is a blocker for many users.

enumag avatar Jul 14 '22 16:07 enumag

@prolic Alternatively, would it be possible to use the non-GUID format of UUIDs in the library (hence allowing uuid v4) and resolve the byte order manually when loading / saving the data in eventstore?

enumag avatar Jul 14 '22 16:07 enumag

I'm not sure, have to look into that.

prolic avatar Jul 15 '22 22:07 prolic