Missing `connectAsync` call in the AggregateRepository blueprint

[gquemener]

trafficstars

I've also detected an issue with the AggregateRepository blueprint as it never calls connectAsync (nor close) on the eventStoreConnection property.

This results in the following error when calling getAggregateRoot:

[2019-12-05 12:55:27] app.DEBUG: EventStoreNodeConnection 'app': enqueing message StartOperationMessage [] []
[2019-12-05 12:55:27] app.DEBUG: EventStoreNodeConnection 'app': enqueing message CloseConnectionMessage [] []
[2019-12-05 12:55:27] app.DEBUG: EventStoreNodeConnection 'app': CloseConnection, reason Connection close requested by client, exception <none> [] []
[2019-12-05 12:55:27] app.DEBUG: EventStoreNodeConnection 'app': CloseTcpConnection IGNORED because connection === null [] []
[2019-12-05 12:55:27] app.INFO: EventStoreNodeConnection 'app': Closed. Reason: Connection close requested by client [] []

[prolic]

Didn't we had this discussion already? I would always only inject a connected resource. The same way, as I would never inject a closed PDO connection somewhere.

[gquemener]

Totally, maybe that could be mentioned somehow in the doc as well?

[prolic]

Sure, find a good place and send a small pull request. I'm happy to merge every improvement.

On Mon, Dec 9, 2019, 15:15 Gildas Quéméner [email protected] wrote:

Totally, maybe that could be mentioned somehow in the doc as well?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/prooph/documentation/issues/8?email_source=notifications&email_token=AADAJPDTW6C7ZUB62C7N7TLQX2DMVA5CNFSM4JV2D7T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGKD5UY#issuecomment-563363539, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADAJPARAAUJ6ZZX2HMXUKDQX2DMVANCNFSM4JV2D7TQ .