rollupid icon indicating copy to clipboard operation
rollupid copied to clipboard

chore(scope): Align provider icons

Open Cosmin-Parvulescu opened this issue 2 years ago • 2 comments

Description

As a developer, I want to have a single entry point for obtaining a JSX.Element of provider icons, so that I may safely extend new features.

Proposed Solution (if applicable)

  • [ ] Wrap icons in design system in JSX.Elements for more features (such as supporting dark mode)
  • [ ] Expose an index.ts with all the elements
  • [ ] Use only that throughout the application

Additional Context (if applicable)

  • As part of #2296 I introduced direct svg elements for Apple & Github so that we may enable dark mode on them. This should be expanded to the other providers and replaced throughout the application.

Cosmin-Parvulescu avatar May 18 '23 08:05 Cosmin-Parvulescu

@Cosmin-Parvulescu @poolsar42 is this still relevant? I think @poolsar42 did this work after the initial implementation. Close if not needed.

betimshahini avatar Jul 31 '23 14:07 betimshahini

@Cosmin-Parvulescu @poolsar42 is this still relevant? I think @poolsar42 did this work after the initial implementation. Close if not needed.

I think we still don't have them all, just the ones affected by dark mode. I'd say we could close the ticket and touch them on a need to basis.

Cosmin-Parvulescu avatar Jul 31 '23 14:07 Cosmin-Parvulescu