pronto icon indicating copy to clipboard operation
pronto copied to clipboard

How to handle reverts which also revert fixed style guide issues?

Open joker-777 opened this issue 7 years ago • 3 comments

Hi,

We were wondering if you have any ideas how to handle reverts which also revert style guide fixes so pronto will fail afterwards.

Thanks!

joker-777 avatar Feb 23 '18 18:02 joker-777

@mmozuras any suggestions on how to deal with this scenario. We might create a big change, which involves some styleguide fixes. But then if we discover a bug, and need to revert quickly, the last thing we need is to also worry about re-applying styleguide fixes again on the revert... Is there any way to tell pronto to skip checks on revert commits? Or any other ideas how to deal with this kind of situation?

gingerlime avatar Aug 02 '18 14:08 gingerlime

Assuming you're talking about GitHub checks on pull request, wouldn't ignoring the check and mergin be enough? Or is it about pronto exit code on CI?

mknapik avatar Aug 31 '18 18:08 mknapik

@mknapik It’s failing the CI build unfortunately...

gingerlime avatar Sep 01 '18 05:09 gingerlime