pronto icon indicating copy to clipboard operation
pronto copied to clipboard
verified publisher icon prontolabs

0 Pronto messages posted to GitHub

Open jasantunes opened this issue 8 years ago • 8 comments

I'm trying to figure out why aren't any the warnings being sent to the PR (the status is being sent though, so I know it's not an auth error).

Here's the output:

$ pronto version
0.9.5

$ PRONTO_GITHUB_ACCESS_TOKEN=XXXXXXXXXX PRONTO_PULL_REQUEST_ID=6032 bin/bundle exec pronto run -c origin/master
app/controllers/application_controller.rb:340 W: Layout/IndentationConsistency: Inconsistent indentation detected. (https://github.com/bbatsov/ruby-style-guide#spaces-indentation)
app/controllers/application_controller.rb:345 W: Layout/EmptyLines: Extra blank line detected. (https://github.com/bbatsov/ruby-style-guide#two-or-more-empty-lines)

$ PRONTO_GITHUB_ACCESS_TOKEN=XXXXXXXXXX PRONTO_PULL_REQUEST_ID=6032 bin/bundle exec pronto run -f github_pr github_status -c origin/master
0 Pronto messages posted to GitHub
Pronto::Rubocop

jasantunes avatar Sep 22 '17 18:09 jasantunes

I have the same issue

artjomjuferov avatar Oct 09 '17 14:10 artjomjuferov

@jasantunes there could be a couple different things going on. Could you add "verbose: true" to .pronto.yml and post the output you get?

mmozuras avatar Oct 20 '17 19:10 mmozuras

Thanks for looking into this @mmozuras! I've created a new testing PR with a couple of rubocop warnings. This is the log from the build/test machine.

+ bundle exec pronto run -c origin/master
Running Pronto::Rubocop
app/controllers/application_controller.rb:346 W: Layout/IndentationConsistency: Inconsistent indentation detected. (https://github.com/bbatsov/ruby-style-guide#spaces-indentation)
app/controllers/application_controller.rb:349 W: Layout/EmptyLines: Extra blank line detected. (https://github.com/bbatsov/ruby-style-guide#two-or-more-empty-lines)
+ PRONTO_GITHUB_ACCESS_TOKEN=<OMITTED>
+ PRONTO_PULL_REQUEST_ID=6383
+ bundle exec pronto run -f github_pr github_status -c origin/master
Running Pronto::Rubocop
Creating a comment from message: #<Pronto::Message:0x00000001a2e850 @path="app/controllers/application_controller.rb", @line=#<struct Pronto::Git::Line line=#<Rugged::Diff::Line:13741200 {line_origin: :addition, content: "   helper_method :url_escape\n">, patch=#<struct Pronto::Git::Patch patch=#<Rugged::Patch:15892220>, repo=#<Pronto::Git::Repository:0x00000001e52620 @repo=#<Rugged::Repository:15898960 {path: "/home/u8466/src/repo/reputedly/.git/"}>>>, hunk=#<Rugged::Diff::Hunk:13741680 {header: "@@ -343,8 +343,10 @@ class ApplicationController < ActionController::Base\n", count: 11}>>, @level=:warning, @msg="Layout/IndentationConsistency: Inconsistent indentation detected. (https://github.com/bbatsov/ruby-style-guide#spaces-indentation)", @runner=Pronto::Rubocop, @commit_sha="98f75ef9ffeb99fa7d13c24c83cdaa738169d39b">
Creating a comment from message: #<Pronto::Message:0x00000001a2d7c0 @path="app/controllers/application_controller.rb", @line=#<struct Pronto::Git::Line line=#<Rugged::Diff::Line:13741000 {line_origin: :addition, content: "\n">, patch=#<struct Pronto::Git::Patch patch=#<Rugged::Patch:15892220>, repo=#<Pronto::Git::Repository:0x00000001e52620 @repo=#<Rugged::Repository:15898960 {path: "/home/u8466/src/repo/reputedly/.git/"}>>>, hunk=#<Rugged::Diff::Hunk:13741680 {header: "@@ -343,8 +343,10 @@ class ApplicationController < ActionController::Base\n", count: 11}>>, @level=:warning, @msg="Layout/EmptyLines: Extra blank line detected. (https://github.com/bbatsov/ruby-style-guide#two-or-more-empty-lines)", @runner=Pronto::Rubocop, @commit_sha="98f75ef9ffeb99fa7d13c24c83cdaa738169d39b">
0 Pronto messages posted to GitHub
Creating comment status on 98f75ef9ffeb99fa7d13c24c83cdaa738169d39b
Pronto::Rubocop

As you can see it finds both warnings and it even posts the status to the PR (0 Pronto messages posted to GitHub). However, no rubocop warnings show up as comments in the PR.

jasantunes avatar Oct 24 '17 00:10 jasantunes

We ran into this issue as well. Any updates?

jmadkins avatar Oct 10 '18 17:10 jmadkins

We ran into the same issue, any updates ?

UtsavPreet avatar Mar 08 '19 11:03 UtsavPreet

same issue ....

oreststetsiak avatar Mar 21 '19 15:03 oreststetsiak

Thanks for looking into this @mmozuras! I've created a new testing PR with a couple of rubocop warnings. This is the log from the build/test machine.

+ bundle exec pronto run -c origin/master
Running Pronto::Rubocop
app/controllers/application_controller.rb:346 W: Layout/IndentationConsistency: Inconsistent indentation detected. (https://github.com/bbatsov/ruby-style-guide#spaces-indentation)
app/controllers/application_controller.rb:349 W: Layout/EmptyLines: Extra blank line detected. (https://github.com/bbatsov/ruby-style-guide#two-or-more-empty-lines)
+ PRONTO_GITHUB_ACCESS_TOKEN=<OMITTED>
+ PRONTO_PULL_REQUEST_ID=6383
+ bundle exec pronto run -f github_pr github_status -c origin/master
Running Pronto::Rubocop
Creating a comment from message: #<Pronto::Message:0x00000001a2e850 @path="app/controllers/application_controller.rb", @line=#<struct Pronto::Git::Line line=#<Rugged::Diff::Line:13741200 {line_origin: :addition, content: "   helper_method :url_escape\n">, patch=#<struct Pronto::Git::Patch patch=#<Rugged::Patch:15892220>, repo=#<Pronto::Git::Repository:0x00000001e52620 @repo=#<Rugged::Repository:15898960 {path: "/home/u8466/src/repo/reputedly/.git/"}>>>, hunk=#<Rugged::Diff::Hunk:13741680 {header: "@@ -343,8 +343,10 @@ class ApplicationController < ActionController::Base\n", count: 11}>>, @level=:warning, @msg="Layout/IndentationConsistency: Inconsistent indentation detected. (https://github.com/bbatsov/ruby-style-guide#spaces-indentation)", @runner=Pronto::Rubocop, @commit_sha="98f75ef9ffeb99fa7d13c24c83cdaa738169d39b">
Creating a comment from message: #<Pronto::Message:0x00000001a2d7c0 @path="app/controllers/application_controller.rb", @line=#<struct Pronto::Git::Line line=#<Rugged::Diff::Line:13741000 {line_origin: :addition, content: "\n">, patch=#<struct Pronto::Git::Patch patch=#<Rugged::Patch:15892220>, repo=#<Pronto::Git::Repository:0x00000001e52620 @repo=#<Rugged::Repository:15898960 {path: "/home/u8466/src/repo/reputedly/.git/"}>>>, hunk=#<Rugged::Diff::Hunk:13741680 {header: "@@ -343,8 +343,10 @@ class ApplicationController < ActionController::Base\n", count: 11}>>, @level=:warning, @msg="Layout/EmptyLines: Extra blank line detected. (https://github.com/bbatsov/ruby-style-guide#two-or-more-empty-lines)", @runner=Pronto::Rubocop, @commit_sha="98f75ef9ffeb99fa7d13c24c83cdaa738169d39b">
0 Pronto messages posted to GitHub
Creating comment status on 98f75ef9ffeb99fa7d13c24c83cdaa738169d39b
Pronto::Rubocop

As you can see it finds both warnings and it even posts the status to the PR (0 Pronto messages posted to GitHub). However, no rubocop warnings show up as comments in the PR.

hi @asantunes ! any luck with this ?

oreststetsiak avatar Mar 22 '19 09:03 oreststetsiak

have some update

ostet@daisy:~/coding/overhaul-backend$pronto run -r reek -f github_pr github_status -c origin/qa
19 Pronto messages posted to GitHub
Pronto::Reek
ostet@daisy:~/coding/overhaul-backend$pronto run -r reek -f github  github_pr github_status -c origin/qa
0 Pronto messages posted to GitHub
0 Pronto messages posted to GitHub
Pronto::Reek
ostet@daisy:~/coding/overhaul-backend$

working fine without github

oreststetsiak avatar Mar 23 '19 17:03 oreststetsiak