proneon267
proneon267
I need some time to prepare the widget list for #2484. In the meantime, you can review this PR whenever you are free. 😊
Apologies. I hadn't noticed the testbed tests were failing after updating to the latest main branch. I'll resolve the issues and request for a review. Thanks :)
Quick question, has there been a major change on adding commands to window toolbars? Looking at the sources: On the core: https://github.com/beeware/toga/blob/bf99b38e895dc2f4e3f43c26251e12e013130c30/core/src/toga/window.py#L946-L975 `toolbar` property is defined only in `MainWindow` On...
I have resolved all of the testbed failures. Furthermore, the testbed tests now make use of additional displays(if available) to test presentation mode. Also, a side question, why was the...
I had a question, as mentioned in the cocoa source: ``` # This doesn't wait for completely exiting full screen mode. Hence, # this will cause problems when rapid window...
By rapid window state switching, I meant directly changing state from PRESENTATION state to FULLSCREEN state or vice-versa. As an example, running the windows example app and first setting window...
Reposting here for better visibility: As previously mentioned in https://github.com/beeware/toga/pull/2473#discussion_r1642620415, I couldn't directly use the following in parametrize: ``` @pytest.mark.parametrize( "windows", [ [], [toga.Window()], [toga.Window(), toga.Window()], ] ) ``` So,...
The macOS testbed failure is not reproducible on my system, and is occasional on the arm64 testbed. I'll try to find the cause. Wayland also seems to be reporting wrong...
All CI errors have been resolved. I've added some review notes in the cocoa source, which I'll remove after the review.
Thanks for the update! No worries, take your time. Good luck with the Python 3.13 release :)