Andrej Mihajlov

I was reading a document describing differences between v1 and v2 and it basically states the following: >"jsonrpc" field added: added a version-field to the Request (and also to the...

While seemingly easy to fix on this end, have you considered raising that issue with the services that go against the protocol? If you are paying for the service, they...

I am not entirely sure it's possible to achieve without adding some attributes, which would be neat! However, you can build the RPC client without using the `jsonrpc_client!` macro. See...

Review status: 0 of 5 files reviewed at latest revision, 16 unresolved discussions. --- *[system-configuration/src/network_configuration.rs, line 260 at r4](https://reviewable.io:443/reviews/mullvad/system-configuration-rs/8#-L5lHuuGgIlcwfCL0wQ6-r4-260:-L5wtw5-1KtQedggoVRO:b-o4a7dv) ([raw file](https://github.com/mullvad/system-configuration-rs/blob/c41a1a5c79355baefccef5831210f95c5520c722/system-configuration/src/network_configuration.rs#L260)):* Previously, faern (Linus Färnstrand) wrote… Nope, we have not...

Reviewed 1 of 9 files at r2, 1 of 4 files at r10, 2 of 4 files at r11. Review status: 4 of 6 files reviewed at latest revision, 31...

Reviewed 1 of 4 files at r11. Review status: 5 of 6 files reviewed at latest revision, 31 unresolved discussions. --- *Comments from [Reviewable](https://beta.reviewable.io/reviews/mullvad/system-configuration-rs/8)*

Reviewed 1 of 4 files at r10. Review status: all files reviewed at latest revision, 31 unresolved discussions. --- *Comments from [Reviewable](https://beta.reviewable.io/reviews/mullvad/system-configuration-rs/8)*

I guess the one could add a static method on `SCDynamicStore` and call the corresponding FFI call with `NULL`

That's a valid point. I re-read the documentation for `SetServiceStatus` today and it makes this one statement: > If the status is SERVICE_STOPPED, perform all necessary cleanup and call SetServiceStatus...

Thanks for thorough investigation on this matter. I am still wrapping my head around it. Ideally we'd probably want to rely on `Drop` semantics and release the `context` automatically with...