wp-pay-core icon indicating copy to clipboard operation
wp-pay-core copied to clipboard

Published 20 hours ago • verified publisher icon pronamic

'Remove all plugin data' setting not working without uninstall method

Open rvdsteege opened this issue 10 months ago • 0 comments

The core library adds a "Remove all plugin data on uninstall" setting on the settings page, even though the plugin might not actually hook register_uninstall_hook() or contain a uninstall.php file. When checked, users can expect the plugin data being removed on uninstall, while nothing will be removed if there are no uninstall methods implemented.

  • https://developer.wordpress.org/plugins/plugin-basics/uninstall-methods/

https://github.com/pronamic/wp-pay-core/blob/6bb82841cb2059e1eceedbafac31d73e5493c4c0/src/Settings.php#L68-L75

https://github.com/pronamic/wp-pay-core/blob/6bb82841cb2059e1eceedbafac31d73e5493c4c0/src/Admin/AdminSettings.php#L73-L87

rvdsteege avatar Apr 03 '24 07:04 rvdsteege