Pixel.Tools icon indicating copy to clipboard operation
Pixel.Tools copied to clipboard

Display update regression? (no update on Midori)

Open 0ion9 opened this issue 9 years ago • 2 comments

Hi, this is the same person who reported the display updating glitches on Pixelation some time ago. I just happened to fire up Midori and found pixel.tools in one of the tabs.

I painted a little and found the exact same effect : the first paint event correctly updates the display, subsequent events do not (but the frame-thumbnail updates).

I checked in Firefox -- it does not have this problem. Midori and Firefox both use the Gecko engine. Therefore, my hypothesis is that Midori does not implement all the javascript functions that Firefox does. If so, this problem may not be fixable, but it would be nice to make sure it is documented.

0ion9 avatar Jul 17 '15 03:07 0ion9

Thanks. I tried installing Midori, but I couldn't run the browser due to some errors. I remember fixing this issue, but perhaps the fix isn't interpreted the same way in the Midori browser. The issue that was causing the problem was related to setting line dashes; Instead of ctx.setLineDash([0]); I had to replace that with ctx.setLineDash([]); ..So if you feel like messing with the code, you can look for the instances of setLineDash and see if any changes to that could fix the issue.

I could probably remove the need to set the linedash to [] if I use save() restore() on the contexts. So that is another thing to check. I may try that when I get some time since I suspect that is the issue.

prominentdetail avatar Jul 17 '15 05:07 prominentdetail

Alright, I committed the discussed change. Also updated the live version at http://pixel.tools If you, 0ion9, or any other Midori users can try it and let me know if it fixes the issue, that would be helpful.

prominentdetail avatar Jul 19 '15 19:07 prominentdetail