test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

Published 20 hours ago • verified publisher icon prometheus

Update `prombench/benchmark` manifests

Open Vandit1604 opened this issue 1 year ago • 7 comments

In this PR, I have

  • updated the version of grafana/promtail to 3.0.0
  • updated deprecated configurations of promtail

Vandit1604 avatar Aug 29 '24 20:08 Vandit1604

Why do we have two configmaps for promtail that look very similar?

bboreham avatar Sep 19 '24 16:09 bboreham

Why is it running 3 promtails? This seems unnecessary.

bboreham avatar Sep 19 '24 16:09 bboreham

This one is to get the logs from each node via tha daemonset https://github.com/prometheus/test-infra/blob/master/prombench/manifests/cluster-infra/6d_promtail_daemon_set.yaml#L34

This promtail has two deployments because for when testing PR and One for testing against a Release. Is there a way to have this deployment conditonally?

https://github.com/prometheus/test-infra/blob/master/prombench/manifests/prombench/benchmark/3c_promtail-bench_deployment.yaml#L169-L179

Vandit1604 avatar Sep 19 '24 23:09 Vandit1604

The DaemonSet only runs on one node, due to https://github.com/prometheus/test-infra/blob/master/prombench/manifests/cluster-infra/6d_promtail_daemon_set.yaml#L124

It’s unnecessary to have all this complication; I’ll fix it.

bboreham avatar Sep 20 '24 06:09 bboreham

Cleanup is in #749. Currently running that config here

BTW the newest promtail appears to be 3.2.0.

bboreham avatar Sep 20 '24 17:09 bboreham

BTW the newest promtail appears to be 3.2.0.

I'll update it to the latest.

Vandit1604 avatar Sep 20 '24 20:09 Vandit1604

Rebased the PR

Vandit1604 avatar Sep 21 '24 11:09 Vandit1604

Solved the merge conflicts. Is there anything that needs to be done for this to get merged?

gentle ping @bboreham

Vandit1604 avatar Oct 02 '24 07:10 Vandit1604