test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

added-binary-arithmetic-operators-logical-operators-topk

Open HarshitNagpal29 opened this issue 1 year ago • 5 comments

Modified the 6_loadgen.yaml file to include tests for the additional PromQL features mentioned in the issue:

  1. Binary Arithmetic Operators (Joins)
  2. Logical Operators (and, or, unless)
  3. TopK

HarshitNagpal29 avatar Aug 21 '24 12:08 HarshitNagpal29

@bboreham sir, can you kindly approve it so that it can be merged?

HarshitNagpal29 avatar Aug 22 '24 12:08 HarshitNagpal29

This needs a DCO sign-off. You can use git commit -s --amend to add it.

SuperQ avatar Aug 30 '24 05:08 SuperQ

For reference, I copied this from http://prombench.prometheus.io/14920/prometheus-release/tsdb-status:

Top 10 series count by metric names

Name Count
codelab_api_request_duration_seconds_bucket 5005000
codelab_api_request_duration_seconds_sum 192500
codelab_api_requests_total 192500
codelab_api_request_duration_seconds_count 192500
codelab_api_request_errors_total 96250
go_gc_duration_seconds 68780
scrape_samples_post_metric_relabeling 13759
scrape_samples_scraped 13759
scrape_duration_seconds 13759
scrape_series_added 13759

bboreham avatar Sep 18 '24 11:09 bboreham

@bboreham Hi Sir, hope you are doing well, thanks for your reply, currently I am having my university exams till the end of this month, so not able to look into this matter for now, but as soon as it will end, I will review it properly and make appropriate changes. Hope you understand.

HarshitNagpal29 avatar Sep 18 '24 12:09 HarshitNagpal29

No problem; I think @kushalShukla-web is going to take a look.

bboreham avatar Sep 18 '24 14:09 bboreham

This was overtaken by #747. Thanks for your contribution!

bboreham avatar Oct 20 '24 17:10 bboreham